Skip to content

Sync with upstream @ 13da0566#467

Merged
joaquinelio merged 7 commits intomasterfrom
sync-13da0566
Jan 15, 2021
Merged

Sync with upstream @ 13da0566#467
joaquinelio merged 7 commits intomasterfrom
sync-13da0566

Conversation

@javascript-translate-bot
Copy link
Copy Markdown

This PR was automatically generated to merge changes from en.javascript.info at 13da056

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

This PR will be closed and replaced with a new one in a few days.

Copy link
Copy Markdown
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vplentinax
sorpresa navideña parece que se tomo vacaciones
y nos ahorramos un super sync

solo dos cambios,

  • un renglón que espero apliques y cerramos (supongo q entendí bien, ojala lo viera alguien con experiencia)
  • el otro lo descarté porque era mio, el repo ingles lo copie del nuestro.

Comment thread 1-js/11-async/08-async-await/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown
Author

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Copy link
Copy Markdown
Member

El bot cerró este PR para cambiarlo por uno nuevo,
si las sync se demoran se desmadra el repo con conflictos y trabajo perdido,

reabro, merge sin review
quien quiera revisar,
haga review post-request y si ve algo mal, PR.

el cambio traduce el texto original aunque creo que ilya deberia cambiarlo

@joaquinelio joaquinelio reopened this Jan 15, 2021
@joaquinelio joaquinelio merged commit 4cfbddd into master Jan 15, 2021
@joaquinelio joaquinelio deleted the sync-13da0566 branch January 15, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants